Re: [PATCH] Revert "jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree()"

[Richard Weinberger]

----- UrsprÃngliche Mail -----
> Von: "Joel Stanley" <joel@xxxxxxxxx>
> An: "David Woodhouse" <dwmw2@xxxxxxxxxxxxx>, "richard" <richard@xxxxxx>, "Jia-Ju Bai" <baijiaju1990@xxxxxxxxx>, "Al
> Viro" <viro@xxxxxxxxxxxxxxxxxx>, "OpenBMC Maillist" <openbmc@xxxxxxxxxxxxxxxx>, "linux-mtd"
> <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-kernel" <linux-kernel@xxxxxxxxxxxxxxx>
> CC: "stable" <stable@xxxxxxxxxxxxxxx>, "Hou Tao" <houtao1@xxxxxxxxxx>
> Gesendet: Freitag, 29. November 2019 01:19:30
> Betreff: [PATCH] Revert "jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree()"

> This reverts commit f2538f999345405f7d2e1194c0c8efa4e11f7b3a. The patch
> stopped JFFS2 from being able to mount an existing filesystem with the
> following errors:
> 
> jffs2: error: (77) jffs2_build_inode_fragtree: Add node to tree failed -22
> jffs2: error: (77) jffs2_do_read_inode_internal: Failed to build final fragtree
> for inode #5377: error -22
> 
> Fixes: f2538f999345 ("jffs2: Fix possible null-pointer dereferences...")
> Cc: stable@xxxxxxxxxxxxxxx
> Suggested-by: Hou Tao <houtao1@xxxxxxxxxx>
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> ---
> 5.4 cannot mount (some?) jffs2 filesystems without this fix. Hou pointed
> this out[1] a while back but the fix didn't make it in. It's still
> broken in -next.

queued into -next.

Thanks,
//richard