Re: [PATCH] drm/qxl: Complete exception handling in qxl_device_init()

[Gerd Hoffmann]

On Thu, Nov 07, 2019 at 06:18:14PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 7 Nov 2019 18:05:08 +0100
> 
> A coccicheck run provided information like the following.
> 
> drivers/gpu/drm/qxl/qxl_kms.c:295:1-7: ERROR: missing iounmap;
> ioremap on line 178 and execution via conditional on line 185
> 
> Generated by: scripts/coccinelle/free/iounmap.cocci
> 
> A jump target was specified in an if branch. The corresponding function
> call did not release the desired system resource then.
> Thus use the label ârom_unmapâ instead to fix the exception handling
> for this function implementation.
> 
> Fixes: 5043348a4969ae1661c008efe929abd0d76e3792 ("drm: qxl: Fix error handling at qxl_device_init")
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Pushed to drm-misc-next.

thanks,
  Gerd