Re: [PATCH 5/6] ARM: dts: stm32: Adapt STM32MP157 DK boards to stm32 DT diversity

[Alexandre Torgue]

On 11/29/19 3:20 PM, Arnd Bergmann wrote:
> On Wed, Nov 20, 2019 at 3:41 PM Alexandre Torgue
> <alexandre.torgue@xxxxxx> wrote:
> > To handle STM32MP15 SOCs diversity, some updates have to been done.
> > This commit mainly adapt dk1 board to include the correct package and the
> > correct SOC version. A new file has been created to factorize common parts.
> >
> > Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxx>
> >
> > diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > index 3f869bd67082..1292ac3b6890 100644
> > --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> > +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> >          model = "STMicroelectronics STM32MP157A-DK1 Discovery Board";
> >          compatible = "st,stm32mp157a-dk1", "st,stm32mp157";
> > -
> > -       aliases {
> > -               ethernet0 = &ethernet0;
> > -               serial0 = &uart4;
> > -       };
> > -
> > -       chosen {
> > -               stdout-path = "serial0:115200n8";
> > -       };
> > -
>
> As a rule, I would leave aliases and chosen nodes in the .dts file and not
> move them into a shared .dtsi, since they tend to be board specific.
>
> (even if that may not be the case in this particular file)

I agree, I'll move them in V2.

Thanks
Alex

>        Arnd