Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded

[JÃrgen GroÃ]

On 29.11.19 16:07, Roger Pau Monnà wrote:
> On Fri, Nov 29, 2019 at 03:02:37PM +0000, Durrant, Paul wrote:
> > > -----Original Message-----
> > > From: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> > > Sent: 29 November 2019 15:00
> > > To: Durrant, Paul <pdurrant@xxxxxxxxxx>
> > > Cc: linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; xen-
> > > devel@xxxxxxxxxxxxxxxxxxxx; Konrad Rzeszutek Wilk
> > > <konrad.wilk@xxxxxxxxxx>; Jens Axboe <axboe@xxxxxxxxx>
> > > Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
> > > unloaded
> > >
> > > On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
> > > > Add a module_exit() to perform the necessary clean-up.
> > > >
> > > > Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> > >
> > > LGTM:
> > >
> > > Reviewed-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> >
> > Thanks.
> >
> > > AFAICT we should make sure this is not committed before patch 1, or
> > > else you could unload a blkback module that's still in use?
> >
> > Yes, that's correct.
>
> Given this is a very small change, and not really block related I
> think it would be better for both patches to be committed from the Xen
> tree, if Jens, Juergen and Boris agree.

I'm fine with that.

And:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen