RE: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table

[Haener, Michael]

> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Freitag, 29. November 2019 11:16
> To: HÃner, Michael (SI BP R&D ZG FW CCP) <michael.haener@xxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>; Darren Hart
> <dvhart@xxxxxxxxxxxxx>; Platform Driver <platform-driver-
> x86@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300
> to critclk_systems DMI table
> 
> On Fri, Nov 29, 2019 at 11:19 AM Michael Haener
> <michael.haener@xxxxxxxxxxx> wrote:
> >
> > The CONNECT X300 uses the PMC clock for on-board components and gets
> > stuck during boot if the clock is disabled. Therefore, add this
> > device to the critical systems list.
> > Tested on CONNECT X300.
> 
> Thank you for your patch!
> Can you be more specific about the clock (which one? For example plt2)
> and if possible type of hardware IP which is connected to it (for
> example, Realtek Ethernet)?

I'm sorry, I don't have more detailed information. I only identified the bug 
by git bisect.

> 
> > Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> > Signed-off-by: Michael Haener <michael.haener@xxxxxxxxxxx>
> > ---
> >  drivers/platform/x86/pmc_atom.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/platform/x86/pmc_atom.c
> b/drivers/platform/x86/pmc_atom.c
> > index 07d1b911e72f..57f06ca114a6 100644
> > --- a/drivers/platform/x86/pmc_atom.c
> > +++ b/drivers/platform/x86/pmc_atom.c
> > @@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[]
> = {
> >                         DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
> >                 },
> >         },
> > +       {
> > +               .ident = "CONNECT X300",
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> > +                       DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
> > +               },
> > +       },
> > +
> >         { /*sentinel*/ }
> >  };
> >
> > --
> > 2.11.0
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko
With Best Regards,
Michael Haener