Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below corresponding function

[Mauro Carvalho Chehab]

Em Wed,  6 Nov 2019 15:37:16 -0300
"Daniel W. S. Almeida" <dwlsalmeida@xxxxxxxxx> escreveu:

> From: "Daniel W. S. Almeida" <dwlsalmeida@xxxxxxxxx>
> 
> Suggested-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@xxxxxxxxx>

Looks OK on my eyes.

> ---
>  drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> index 4db679cb70ad..909dac2345c4 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
>  
> @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
>  
> @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
>  	.delsys = { SYS_DVBT },
> @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
>  MODULE_DESCRIPTION("DVB DUMMY Frontend");
>  MODULE_AUTHOR("Emard");
>  MODULE_LICENSE("GPL");
> -
> -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);



Cheers,
Mauro