Re: [PATCH 2/2] arm64: dts: Add GPC Support

From: Fabio Estevam
Date: Sat Nov 30 2019 - 17:31:07 EST


On Sat, Nov 30, 2019 at 7:25 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Adam,
>
> On Fri, Nov 29, 2019 at 8:41 PM Adam Ford <aford173@xxxxxxxxx> wrote:
>
> > +
> > + gpc: gpc@303a0000 {
> > + compatible = "fsl,imx8mm-gpc";
>
> You could do like this instead:
>
> compatible = "fsl,imx8mm-gpc", "fsl,imx8mq-gpc";
>
> and then you don't need patch 1/2.
>
> Also, "fsl,imx8mm-gpc" needs to be documented.

One more thing: when you add a v2, please specify the SoC name in the
subject line:

arm64: dts: imx8mm: Add GPC Support