Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

From: Simon Horman
Date: Sat Dec 07 2019 - 12:13:47 EST


On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
> #size-cells properties, correct those.
>
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Thanks Florian,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxxx>

> ---
> arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
> mdio: mdio@18002000 {
> compatible = "brcm,iproc-mdio";
> reg = <0x18002000 0x8>;
> - #size-cells = <1>;
> - #address-cells = <0>;
> + #size-cells = <0>;
> + #address-cells = <1>;
> status = "disabled";
>
> gphy0: ethernet-phy@0 {
> --
> 2.17.1
>