Re: [RFC 19/25] leds: tm1628: Add 7-segment display support

[Geert Uytterhoeven]

Hi Andreas,

On Thu, Dec 12, 2019 at 4:42 AM Andreas FÃrber <afaerber@xxxxxxx> wrote:
> Detect DT child nodes covering more than one LED component and implement
> a text to 7-segment display mapping.
>
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>

> --- a/drivers/leds/leds-tm1628.c
> +++ b/drivers/leds/leds-tm1628.c

> +static const struct tm1628_ssd_char tm1628_char_ssd_map[] = {
> +       { '0', SSD_TOP | SSD_TOP_LEFT | SSD_TOP_RIGHT |
> +              SSD_BOTTOM_LEFT | SSD_BOTTOM_RIGHT | SSD_BOTTOM },

Please use include/uapi/linux/map_to_7segment.h
Yes, it is well hidden ;-).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds