Re: [RFC 19/25] leds: tm1628: Add 7-segment display support

[Andreas FÃrber]

Hi Geert,

Am 12.12.19 um 09:33 schrieb Geert Uytterhoeven:
> On Thu, Dec 12, 2019 at 4:42 AM Andreas FÃrber <afaerber@xxxxxxx> wrote:
>> Detect DT child nodes covering more than one LED component and implement
>> a text to 7-segment display mapping.
>>
>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
> 
>> --- a/drivers/leds/leds-tm1628.c
>> +++ b/drivers/leds/leds-tm1628.c
> 
>> +static const struct tm1628_ssd_char tm1628_char_ssd_map[] = {
>> +       { '0', SSD_TOP | SSD_TOP_LEFT | SSD_TOP_RIGHT |
>> +              SSD_BOTTOM_LEFT | SSD_BOTTOM_RIGHT | SSD_BOTTOM },
> 
> Please use include/uapi/linux/map_to_7segment.h
> Yes, it is well hidden ;-).

Many thanks for that pointer! Even matches the segment/bit order of my
datasheets/defines.

The small t may be different (T?), and I don't see it mapping combined
characters (patch 22/25). The recommended sysfs map_7seg attribute may
help deal with that, but seems terribly unhandy for my busybox initrd.

Hope you also read the cover letter, where not finding this and many
other issues were discussed. I was expecting some .c file in either
drivers/leds or auxdisplay - input is indeed unexpected for output.

Still wondering whether we can somehow describe those "VFD" displays in
a more reusable way, like we do for MIPI DSI panels.

Cheers,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer
HRB 36809 (AG NÃrnberg)