Re: [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings

[Maxime Ripard]

Hi,

On Tue, Dec 10, 2019 at 04:36:30PM +0800, Kevin Tang wrote:
> From: Kevin Tang <kevin.tang@xxxxxxxxxx>
>
> DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs
> which transfers the image data from a video memory buffer to an internal
> LCD interface.
>
> Cc: Orson Zhai <orsonzhai@xxxxxxxxx>
> Cc: Baolin Wang <baolin.wang@xxxxxxxxxx>
> Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
> Signed-off-by: Kevin Tang <kevin.tang@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/display/sprd/dpu.txt       | 55 ++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/sprd/dpu.txt
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/dpu.txt b/Documentation/devicetree/bindings/display/sprd/dpu.txt
> new file mode 100644
> index 0000000..25cbf8e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/dpu.txt
> @@ -0,0 +1,55 @@
> +Unisoc SoC Display Processor Unit (DPU)
> +============================================================================
> +
> +DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs
> +which transfers the image data from a video memory buffer to an internal
> +LCD interface.
> +
> +Required properties:
> +  - compatible: value should be "sprd,display-processor";
> +  - reg: physical base address and length of the DPU registers set.
> +  - interrupts: the interrupt signal from DPU.
> +  - clocks: must include clock specifiers corresponding to entries in the
> +	    clock-names property.
> +  - clock-names: list of clock names sorted in the same order as the clocks
> +                 property.

Same story, this should be a YAML schemas, but here you should
describe what the expected clock-names are, and what clock they
represent.

> +  - dma-coherent: with this property, the dpu driver can allocate large and
> +		  continuous memorys.
> +  - port: a port node with endpoint definitions as defined in document [1].

So only one? Connected to what?

Maxime

Attachment: signature.asc
Description: PGP signature