Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes

From: Rob Herring
Date: Fri Dec 13 2019 - 16:34:22 EST


On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote:
> Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO
> descriptors"), the prefered way to define chipselect GPIOs is using
> 'cs-gpios' property instead of the legacy 'gpios' property.

This will break using a new dtb on a kernel without the above commit. Or
with any OS that never made the change.

I'm fine with the doc change, but you should keep 'gpios' as deprecated.

>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> Documentation/devicetree/bindings/spi/fsl-spi.txt | 8 ++++----
> arch/powerpc/boot/dts/mgcoge.dts | 2 +-
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +-
> arch/powerpc/boot/dts/mpc8610_hpcd.dts | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)