Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes

From: Christophe Leroy
Date: Sat Dec 14 2019 - 02:33:15 EST




Le 13/12/2019 Ã 22:34, Rob Herring a ÃcritÂ:
On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote:
Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO
descriptors"), the prefered way to define chipselect GPIOs is using
'cs-gpios' property instead of the legacy 'gpios' property.

This will break using a new dtb on a kernel without the above commit. Or
with any OS that never made the change.

Why would anybody use a new dtb on an old kernel ? I have not tagged this change for stable, it will only apply to DTBs in new kernels, won't it ?

That's not the first time DTS have to change for new kernels. For instance, some time ago I had to replace all 'gpios' property by a set of 'rdy-gpio', 'nce-gpio', 'ale-gpio' and 'cle-gpio' properties to continue using 'gpio-control-nand' driver.


I'm fine with the doc change, but you should keep 'gpios' as deprecated.

Ok

Christophe