Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

[youling 257]

only Revert "fs: remove ksys_dup()", not see the warning
"/system/bin/sh: No controlling tty: open /dev/tty: No such device or
address."

yes, "fs: remove ksys_dup()" caused my system/bin/sh problem.

but test "early init: fix error handling when opening /dev/console",
still can see "/system/bin/sh: No controlling tty" warning, it not
solve my problem.


2019-12-18 5:14 GMT+08:00, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>:
> This should be fixed by 2d3145f8d280 ("early init: fix error handling
> when opening /dev/console")
>
> I'm not sure what you did to trigger that bug, but it was a bug.
>
>               Linus
>
>
> On Tue, Dec 17, 2019 at 1:34 AM youling 257 <youling257@xxxxxxxxx> wrote:
>>
>> I had been Revert "fs: remove ksys_dup()" Revert "init: unify opening
>> /dev/console as stdin/stdout/stderr", test boot, n the system/bin/sh
>> warning.
>