Re: [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr

From: Dominik Brodowski
Date: Wed Dec 18 2019 - 03:03:55 EST


On Wed, Dec 18, 2019 at 12:10:08PM +0800, youling 257 wrote:
> only Revert "fs: remove ksys_dup()", not see the warning
> "/system/bin/sh: No controlling tty: open /dev/tty: No such device or
> address."
>
> yes, "fs: remove ksys_dup()" caused my system/bin/sh problem.
>
> but test "early init: fix error handling when opening /dev/console",
> still can see "/system/bin/sh: No controlling tty" warning, it not
> solve my problem.

FWIW, I see a similar (seemingly harmless) warning both _before_ and
after my patches, so I am not sure that this is a real regression.

Thanks,
Dominik