Re: [PATCH][next] drm/i915: fix uninitialized pointer reads on pointers to and from

From: Chris Wilson
Date: Thu Dec 19 2019 - 14:43:17 EST


Quoting Colin King (2019-12-19 19:09:16)
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently pointers to and from are not initialized and may contain
> garbage values. This will cause uninitialized pointer reads in the
> call to intel_frontbuffer_track and later checks to see if to and from
> are null. Fix this by ensuring to and from are initialized to NULL.
>
> Addresses-Coverity: ("Uninitialised pointer read)"
> Fixes: da42104f589d ("drm/i915: Hold reference to intel_frontbuffer as we track activity")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

"D'oh"
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris