Re: [PATCH AUTOSEL 5.4 177/350] regulator: fixed: add off-on-delay

From: Sasha Levin
Date: Thu Dec 19 2019 - 14:40:18 EST


On Wed, Dec 11, 2019 at 10:59:34AM +0000, Mark Brown wrote:
On Tue, Dec 10, 2019 at 04:04:42PM -0500, Sasha Levin wrote:
From: Peng Fan <peng.fan@xxxxxxx>

[ Upstream commit f7907e57aea2adcd0b57ebcca410e125412ab680 ]

Depends on board design, the gpio controlling regulator may
connects with a big capacitance. When need off, it takes some time
to let the regulator to be truly off. If not add enough delay, the
regulator might have always been on, so introduce off-on-delay to
handle such case.

This is clearly adding a new feature and doesn't include the matching DT
binding addition for that new feature.

This new "feature" fixes a bug, no? Should we take the DT bindings as
well?

--
Thanks,
Sasha