Re: [PATCH AUTOSEL 5.4 177/350] regulator: fixed: add off-on-delay

[Mark Brown]

On Thu, Dec 19, 2019 at 02:40:12PM -0500, Sasha Levin wrote:
> On Wed, Dec 11, 2019 at 10:59:34AM +0000, Mark Brown wrote:
> > On Tue, Dec 10, 2019 at 04:04:42PM -0500, Sasha Levin wrote:

> > > Depends on board design, the gpio controlling regulator may
> > > connects with a big capacitance. When need off, it takes some time
> > > to let the regulator to be truly off. If not add enough delay, the
> > > regulator might have always been on, so introduce off-on-delay to
> > > handle such case.

> > This is clearly adding a new feature and doesn't include the matching DT
> > binding addition for that new feature.

> This new "feature" fixes a bug, no? Should we take the DT bindings as
> well?

This new feature enables support for new hardware which would not
otherwise be supported if someone also updates the DT for the system.
Most features are on some level a bugfix for the lack of whatever the
feature is, this is on a similar level to adding a new device driver
(some device drivers are about as complex!).  It's a good change but it
doesn't seem to fit into what stable is supposed to be doing.

If you are backporting features that need new DT bindings then yes, you
should be backporting the bindings as well but that's a pretty good
indication that it's adding a feature.

Attachment: signature.asc
Description: PGP signature