Re: [PATCH] drm/bridge: cdns: remove set but not used variable 'nlanes'

From: Neil Armstrong
Date: Mon Jan 06 2020 - 10:08:07 EST


On 26/12/2019 13:14, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/bridge/cdns-dsi.c: In function âcdns_dsi_mode2cfgâ:
> drivers/gpu/drm/bridge/cdns-dsi.c:515:11: warning: variable ânlanesâ
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/cdns-dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c
> index 3a5bd4e7fd1e..a6ab2d281a9b 100644
> --- a/drivers/gpu/drm/bridge/cdns-dsi.c
> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c
> @@ -512,7 +512,7 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> struct cdns_dsi_output *output = &dsi->output;
> unsigned int tmp;
> bool sync_pulse = false;
> - int bpp, nlanes;
> + int bpp;
>
> memset(dsi_cfg, 0, sizeof(*dsi_cfg));
>
> @@ -520,7 +520,6 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> sync_pulse = true;
>
> bpp = mipi_dsi_pixel_format_to_bpp(output->dev->format);
> - nlanes = output->dev->lanes;
>
> if (mode_valid_check)
> tmp = mode->htotal -
>


Reviewed-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>

and applying to drm-misc-next