Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate
From: John Stultz
Date: Tue Jan 07 2020 - 12:23:37 EST
On Tue, Jan 7, 2020 at 12:32 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> On Tue, 2020-01-07 at 01:03 +0000, John Stultz wrote:
> > Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> > to allow for the driver to be loaded from a modules.
> > Cc: Todd Kjos <tkjos@xxxxxxxxxx>
> > Cc: Alistair Delva <adelva@xxxxxxxxxx>
> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Cc: Amit Pundir <amit.pundir@xxxxxxxxxx>
> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> > ---
> > drivers/reset/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 3ad7817ce1f0..45e70524af36 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> > This enables the reset driver for ImgTec Pistachio SoCs.
> > config RESET_QCOM_AOSS
> > - bool "Qcom AOSS Reset Driver"
> > + tristate "Qcom AOSS Reset Driver"
> This doesn't seem right on its own, the driver still uses
Huh. Thanks for pointing that out!
It seems like it was working fine as a module with just the kconfig
change, but let me double check this and I'll revise with a follow-on
patch to address this bit.
Very much appreciate the review!