Re: [PATCH] locking/qspinlock: Fix inaccessible URL of MCS lock paper
From: Will Deacon
Date: Tue Jan 07 2020 - 12:23:51 EST
On Tue, Jan 07, 2020 at 09:14:20AM -0500, Waiman Long wrote:
> On 1/7/20 8:09 AM, Peter Zijlstra wrote:
> > On Tue, Jan 07, 2020 at 01:58:24PM +0100, Peter Zijlstra wrote:
> >> On Sun, Dec 22, 2019 at 09:25:32PM -0500, Waiman Long wrote:
> >>> It turns out that the URL of the MCS lock paper listed in the source
> >>> code is no longer accessible. I did got question about where the paper
> >>> was. This patch updates the URL to one that is still accessible.
> >>> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
> >>> ---
> >>> kernel/locking/qspinlock.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c
> >>> index 2473f10c6956..1d008d2333c0 100644
> >>> --- a/kernel/locking/qspinlock.c
> >>> +++ b/kernel/locking/qspinlock.c
> >>> @@ -34,7 +34,7 @@
> >>> * MCS lock. The paper below provides a good description for this kind
> >>> * of lock.
> >>> *
> >>> - * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf
> >>> + * https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf
> >> Do we want to stick a copy of the paper in our bugzilla and link that
> >> instead? ISTR we do something similar elsewhere, but I'm having trouble
> >> finding it.
> >> Thomas, Konstantin?
> > Boris provided an example from commit:
> > 018ebca8bd70 ("x86/cpufeatures: Enable a new AVX512 CPU feature")
> > That puts a copy of the relevant Intel document here:
> > https://bugzilla.kernel.org/show_bug.cgi?id=204215
> OK, that sounds good. I will put a copy of the paper in the BZ and
> linked it there.
Thanks. When you update the link in the comment, please can you also include
the title of the paper. i.e.
The paper below ("Algorithms for Scalable Synchronization on Shared-Memory
Multiprocessors by Mellor-Crummey and Scott") ...
That makes the thing a lot more searchable in case bugzilla is getting DoS'd