Re: [PATCH -next] ext4: remove unused variable 'mapping'

From: Darrick J. Wong
Date: Tue Jan 07 2020 - 18:16:42 EST


On Tue, Jan 07, 2020 at 02:23:55PM +0800, YueHaibing wrote:
> fs/ext4/inode.c: In function 'ext4_page_mkwrite':
> fs/ext4/inode.c:5910:24: warning: unused variable 'mapping' [-Wunused-variable]
>
> commit 4a58d8158f6d ("fs: Fix page_mkwrite off-by-one errors")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Er, I had to rebase the branch this morning to remove the f2fs parts
(there's a conflict and they never acked the patch) so I cleaned this up
at the same time.

--D

> ---
> fs/ext4/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9a3e8d0..d0049fd 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5907,7 +5907,6 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
> vm_fault_t ret;
> struct file *file = vma->vm_file;
> struct inode *inode = file_inode(file);
> - struct address_space *mapping = inode->i_mapping;
> handle_t *handle;
> get_block_t *get_block;
> int retries = 0;
> --
> 2.7.4
>
>