Re: [PATCH] [net-next] [v2] socket: fix unused-function warning

From: Al Viro
Date: Wed Jan 08 2020 - 16:56:15 EST


On Wed, Jan 08, 2020 at 10:44:43PM +0100, Arnd Bergmann wrote:
> When procfs is disabled, the fdinfo code causes a harmless
> warning:
>
> net/socket.c:1000:13: error: 'sock_show_fdinfo' defined but not used [-Werror=unused-function]
> static void sock_show_fdinfo(struct seq_file *m, struct file *f)
>
> Move the function definition up so we can use a single #ifdef
> around it.

Looks sane...