Re: [PATCH] [net-next] [v2] socket: fix unused-function warning

From: David Miller
Date: Wed Jan 08 2020 - 18:02:48 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Wed, 8 Jan 2020 22:44:43 +0100

> When procfs is disabled, the fdinfo code causes a harmless
> warning:
>
> net/socket.c:1000:13: error: 'sock_show_fdinfo' defined but not used [-Werror=unused-function]
> static void sock_show_fdinfo(struct seq_file *m, struct file *f)
>
> Move the function definition up so we can use a single #ifdef
> around it.
>
> Fixes: b4653342b151 ("net: Allow to show socket-specific information in /proc/[pid]/fdinfo/[fd]")
> Suggested-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Acked-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied, thanks Arnd.