Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls

From: Julia Lawall
Date: Fri Jan 10 2020 - 07:34:45 EST




On Fri, 10 Jan 2020, Markus Elfring wrote:

> > +@initialize:python@
> â
> > +def construct_warnings(str, suggested_fun):
>
> This function will be used only for the operation modes âorgâ and âreportâ.
> Thus I suggest to replace the specification âinitializeâ by a corresponding dependency
> which is already applied for the SmPL rule ârâ.
>
>
> Can subsequent SmPL disjunctions become more succinct?
>
>
> The passing of function name variants contains a bit of duplicate Python code.
> Will a feature request like âSupport for SmPL rule groupsâ become more interesting
> for the shown use case?
> https://github.com/coccinelle/coccinelle/issues/164

The code is fine as it is in these respects.

julia