Re: [PATCH v2 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings

[Taniya Das]

Hi Rob,

Thanks for your review.

On 1/5/2020 3:06 AM, Rob Herring wrote:

> > +description: |
> > +  Qualcomm modem clock control module which supports the clocks.
> > +
> > +properties:
> > +  compatible :
>
> drop space     ^

Will take care in the next patch.

> > +    enum:
> > +       - qcom,sc7180-mss
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  additionalItems: false
>
> With the indentation here, you are defining a property. Should be no
> indent.

I tried removing the indent too, but I keep getting this error.
 Additional properties are not allowed ('additionalItems' was unexpected)

Please let me know if I am missing something?

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - '#clock-cells'
> > +
> > +examples:
> > +  # Example of MSS with clock nodes properties for SC7180:
> > +  - |
> > +    clock-controller@41aa000 {
> > +      compatible = "qcom,sc7180-mss";
> > +      reg = <0x041aa000 0x100>;
> > +      #clock-cells = <1>;
> > +    };
> > +...
> > --
> > Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> > of the Code Aurora Forum, hosted by the  Linux Foundation.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--