Re: [PATCH v2 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings
From: Rob Herring
Date: Mon Jan 13 2020 - 11:21:39 EST
On Mon, Jan 13, 2020 at 4:00 AM Taniya Das <tdas@xxxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> Thanks for your review.
>
> On 1/5/2020 3:06 AM, Rob Herring wrote:
>
> >> +description: |
> >> + Qualcomm modem clock control module which supports the clocks.
> >> +
> >> +properties:
> >> + compatible :
> >
> > drop space ^
> >
>
> Will take care in the next patch.
>
> >> + enum:
> >> + - qcom,sc7180-mss
> >> +
> >> + '#clock-cells':
> >> + const: 1
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + additionalItems: false
> >
> > With the indentation here, you are defining a property. Should be no
> > indent.
> >
>
> I tried removing the indent too, but I keep getting this error.
> Additional properties are not allowed ('additionalItems' was unexpected)
>
> Please let me know if I am missing something?
Sorry, I was reading that as 'additionalProperties' which is what you
want at the top level. Generally, 'additionalItems' is not needed.
Rob