Re: [PATCH next] ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

From: Codrin.Ciubotariu
Date: Mon Jan 13 2020 - 11:21:45 EST


On 13.01.2020 15:32, Chen Zhou wrote:
> If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
>
> sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
> (.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
>
> Function atmel_pcm_dma_platform_register is defined under
> CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in
> CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620

It wasn't merged due to some integration issues. Could you please try it
and let us know if it fixes your issue?

Thanks and best regards,
Codrin

>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
> ---
> sound/soc/atmel/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index f118c22..d1dc8e6 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
>
> config SND_ATMEL_SOC_SSC
> tristate
> + select SND_ATMEL_SOC_DMA
> + select SND_ATMEL_SOC_PDC
>
> config SND_ATMEL_SOC_SSC_PDC
> tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> --
> 2.7.4
>