Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string

[Vinod Koul]

On 27-01-20, 08:23, Douglas Anderson wrote:
> As per the bindings, the SDHCI controller should have a SoC-specific
> compatible string in addition to the generic version-based one.  Add
> it.

Thanks for spotting it Doug, Btw did some script catch it or manual
inspection?


Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>

> Fixes: 7241ab944da3 ("arm64: dts: qcom: qcs404: Add sdcc1 node")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
> 
>  arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 4ee1e3d5f123..1eea06435779 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -685,7 +685,7 @@ pcie_phy: phy@7786000 {
>  		};
>  
>  		sdcc1: sdcc@7804000 {
> -			compatible = "qcom,sdhci-msm-v5";
> +			compatible = "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5";
>  			reg = <0x07804000 0x1000>, <0x7805000 0x1000>;
>  			reg-names = "hc_mem", "cmdq_mem";
>  
> -- 
> 2.25.0.341.g760bfbb309-goog

-- 
~Vinod