Re: [PATCH] arm64: dts: qcom: qcs404: Fix sdhci compat string

From: Doug Anderson
Date: Mon Jan 27 2020 - 12:08:06 EST


Hi,

On Mon, Jan 27, 2020 at 9:05 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> On 27-01-20, 08:23, Douglas Anderson wrote:
> > As per the bindings, the SDHCI controller should have a SoC-specific
> > compatible string in addition to the generic version-based one. Add
> > it.
>
> Thanks for spotting it Doug, Btw did some script catch it or manual
> inspection?
>
>
> Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>

It probably would have been spotted by "make dtbs_check", but I wasn't
running that in this case. I just happened to notice it while
chatting with someone at Qualcomm about whether
<https://crrev.com/c/2022985> was correct (still waiting for a
response on that).

-Doug