Re: [PATCH] dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml

[Rob Herring]

On Mon, Jan 27, 2020 at 6:21 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote:
>
>
>
> On 24/01/20 7:59 pm, Dafna Hirschfeld wrote:
> >
> >
> > On 24.01.20 15:03, Rob Herring wrote:
> >> On Fri, Jan 24, 2020 at 5:49 AM Dafna Hirschfeld
> >> <dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
> >>>
> >>> Running:
> >>> export
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> >>>
> >>> 'make dt_binding_check'
> >>>
> >>> gives a compilation error. This is because in the example there
> >>> is the label 'emmc-phy' but labels are not allowed to have '-' sing.
> >>> Replace the '-' with '_' to fix the error.
> >>>
> >>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> >>
> >> There's a fix from the author, but you're first to get the fix
> >> correct, so:
> > Oh, sorry, I was not aware of that.
> > Dafna
> >
> >>
> >> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
> >> schema for LGM eMMC PHY")
> >> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> >>
> >> Kishon, Please apply these soon as linux-next is broken.
> >>
>
> merged now, Thanks!

And please drop or revert this. It's still has failures:

Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:23.13-33:
Warning (reg_format): /example-0/chiptop@e0200000/emmc-phy@a8:reg:
property has invalid length (8 bytes) (#address-cells == 2,
#size-cells == 1)
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dt.yaml:
Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.33-26.13:
Warning (avoid_default_addr_size):
/example-0/chiptop@e0200000/emmc-phy@a8: Relying on default
#address-cells value
Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.33-26.13:
Warning (avoid_default_addr_size):
/example-0/chiptop@e0200000/emmc-phy@a8: Relying on default
#size-cells value


I'll send out a complete fix and take via the DT tree so maybe we can
have an rc1 that works.

Rob