Re: [PATCH] KVM: x86: fix WARN_ON check of an unsigned less than zero

From: linmiaohe
Date: Wed Feb 12 2020 - 07:47:42 EST


Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:
> The check cpu->hv_clock.system_time < 0 is redundant since system_time is a u64 and hence can never be less than zero. But what was actually meant is to check that the result is positive, since kernel_ns and
> v->kvm->arch.kvmclock_offset are both s64.
>
>Reported-by: Colin King <colin.king@xxxxxxxxxxxxx>
>Suggested-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
>Addresses-Coverity: ("Macro compares unsigned to 0")
>Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>---

Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>