Re: [PATCH v3 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima

[Tushar Sugandhi]

On 2020-02-12 6:49 a.m., Mimi Zohar wrote:
> On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote:
> > Log statements from ima_mok.c, ima_asymmetric_keys.c, and
> > ima_queue_keys.c are prefixed with the respective file names
> > and not with the string "ima".
>
> Before listing the specific filenames, the patch description should
> provide a generic explanation of the problem. ÂFor example, the kernel
> Makefile "obj-$CONFIG_XXXX" specifies object files which may be built
> as loadable kernel modules[1].
Thanks Mimi. I will update the patch description in the next iteration.


> Mimi
>
> [1] Refer toÂDocumentation/kbuild/makefiles.rst
>
> > This change fixes the log statement prefix to be consistent with the rest
> > of the IMA files.
> >
> > Signed-off-by: Tushar Sugandhi <tusharsu@xxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx>
> > ---
> >   security/integrity/ima/Makefile | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/security/integrity/ima/Makefile b/security/integrity/ima/Makefile
> > index 064a256f8725..67dabca670e2 100644
> > --- a/security/integrity/ima/Makefile
> > +++ b/security/integrity/ima/Makefile
> > @@ -11,6 +11,6 @@ ima-y := ima_fs.o ima_queue.o ima_init.o ima_main.o ima_crypto.o ima_api.o \
> >   ima-$(CONFIG_IMA_APPRAISE) += ima_appraise.o
> >   ima-$(CONFIG_IMA_APPRAISE_MODSIG) += ima_modsig.o
> >   ima-$(CONFIG_HAVE_IMA_KEXEC) += ima_kexec.o
> > -obj-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
> > -obj-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
> > -obj-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o
> > +ima-$(CONFIG_IMA_BLACKLIST_KEYRING) += ima_mok.o
> > +ima-$(CONFIG_IMA_MEASURE_ASYMMETRIC_KEYS) += ima_asymmetric_keys.o
> > +ima-$(CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS) += ima_queue_keys.o