Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially

From: Kirill A. Shutemov
Date: Fri Feb 14 2020 - 10:40:04 EST


On Thu, Feb 13, 2020 at 04:38:01PM -0800, Yang Shi wrote:
> Hi Kirill,
>
>
> Would you please help review this patch? I don't know why Hugh didn't
> response though I pinged him twice.

I have not noticed anything wrong with the patch.

But the function gets ugly beyond the reason. Any chance you could
restructure it to get somewhat maintainable? (It's not easy, I know).

--
Kirill A. Shutemov