Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially

From: Yang Shi
Date: Fri Feb 14 2020 - 12:17:56 EST

Next message: Gustavo A. R. Silva: "[PATCH] Input: tca6416-keypad - replace zero-length array with flexible-array member"
Previous message: Sasha Levin: "[PATCH AUTOSEL 5.4 444/459] iwlwifi: mvm: Check the sta is not NULL in iwl_mvm_cfg_he_sta()"
In reply to: Kirill A. Shutemov: "Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 2/14/20 7:40 AM, Kirill A. Shutemov wrote:

On Thu, Feb 13, 2020 at 04:38:01PM -0800, Yang Shi wrote:

Hi Kirill,

Would you please help review this patch? I don't know why Hugh didn't
response though I pinged him twice.

I have not noticed anything wrong with the patch.

But the function gets ugly beyond the reason. Any chance you could
restructure it to get somewhat maintainable? (It's not easy, I know).

Yes, those goto looks not neat. I'm going to give it a try. Any suggestion is absolutely welcome.

Next message: Gustavo A. R. Silva: "[PATCH] Input: tca6416-keypad - replace zero-length array with flexible-array member"
Previous message: Sasha Levin: "[PATCH AUTOSEL 5.4 444/459] iwlwifi: mvm: Check the sta is not NULL in iwl_mvm_cfg_he_sta()"
In reply to: Kirill A. Shutemov: "Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]