Re: [PATCH] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status()

From: Wolfram Sang
Date: Tue Mar 24 2020 - 07:09:34 EST



> } while (time_is_after_jiffies(target));
>
> - if (time_is_before_jiffies(target)) {
> + if (time_is_before_eq_jiffies(target)) {

While unlikely, there is a tiny race between the time_is_* calls,
jiffies could update inbetween them.

So, for the sake of good programming practice, I'd recommend to set a
flag in the do_while-loop and the have the logic above solely based on
the flag.

Attachment: signature.asc
Description: PGP signature