Re: [PATCH 2/2] media: coda: be more flexible wrt jpeg dimensions

[Adrian Ratiu]

On Tue, 24 Mar 2020, Philipp Zabel <pza@xxxxxxxxxxxxxx> wrote:
> Hi Adrian, 
>
> On Mon, Mar 23, 2020 at 03:09:37PM +0200, Adrian Ratiu wrote: 
> > Don't require jpeg dimensions to exactly match format 
> > dimensions, so we are able to decode and display a wider range 
> > jpegs instead of outright rejecting the ones which don't match. 
>
> I don't think this is right. If userspace feeds us an 
> incomatible JPEG we should probably stop decoding and send a 
> source change event instead [1]. 

Please ignore this second patch as it abuses the spec as Ezequiel
mentioned in the other reply. The correct approach would be to
do a format renegotiation in userspace so the test can be passed.

I will send an updated v2 of the huffman table patch based on
your feedback.

Thank you,
Adrian

> [1] https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/dev-decoder.html#dynamic-resolution-change
>
> regards
> Philipp