Re: [PATCH v11 10/12] backlight: pwm_bl: Use 64-bit division function

From: Daniel Thompson
Date: Tue Mar 24 2020 - 09:04:18 EST


On Tue, Mar 24, 2020 at 01:57:35PM +0100, Uwe Kleine-König wrote:
> Hello Lee,
>
> On Tue, Mar 24, 2020 at 11:07:10AM +0000, Lee Jones wrote:
> > On Fri, 20 Mar 2020, Lee Jones wrote:
> >
> > > On Thu, 19 Mar 2020, Guru Das Srinagesh wrote:
> > >
> > > > Since the PWM framework is switching struct pwm_state.period's datatype
> > > > to u64, prepare for this transition by using div_u64 to handle a 64-bit
> > > > dividend instead of a straight division operation.
> > > >
> > > > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > > > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > > > Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > > > Cc: linux-pwm@xxxxxxxxxxxxxxx
> > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > > Cc: linux-fbdev@xxxxxxxxxxxxxxx
> > > >
> > > > Signed-off-by: Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx>
> > > > Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > > > ---
> > > > drivers/video/backlight/pwm_bl.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > Can this patch be taken on its own?
> >
> > Hellooooo ...
>
> Conceptually it can. As the last patch depends on this one (and the
> others) some coordination might be beneficial. But that's up to Thierry
> to decide how (and if) he want this series to be applied.

... and on the backlight side we definitely need to know about the "if"
otherwise there's no point in taking it.


Daniel.