Re: [PATCH 01/13] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic GXL and GXM Families USB Glue Bindings

[Neil Armstrong]

On 24/03/2020 15:06, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
> [...]
>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
>> @@ -25,9 +25,13 @@ description: |
>>    The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in
>>    host-only mode.
>>
>> +  The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY.
>> +
>>  properties:
>>    compatible:
>>      enum:
>> +      - amlogic,meson-gxl-usb-ctrl
>> +      - amlogic,meson-gxm-usb-ctrl
>>        - amlogic,meson-g12a-usb-ctrl
>>        - amlogic,meson-a1-usb-ctrl
> the phy-names property is described below which you don't update
> please add usb2-phy2 to the list of allowed phy-names so the dt
> binding validation for the .dtsi patche (#9) won't complain

Missed this one, thanks !

Neil

> 
> With that fixed:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> 
> 
> Martin
>