Re: [PATCH] perf script: add flamegraph.py script

[Arnaldo Melo]

On March 24, 2020 4:05:15 PM GMT-03:00, Andreas Gerstmayr <agerstmayr@xxxxxxxxxx> wrote:
>On 24.03.20 17:16, Kim Phillips wrote:
>> On Ubuntu 19.10, where python 2.7 is still the default, I get:
>> 
>> $ perf script report flamegraph
>>    File "/usr/libexec/perf-core/scripts/python/flamegraph.py", line
>46
>>      print(f"Flame Graph template {self.args.template} does not " +
>>                                                                 ^
>> SyntaxError: invalid syntax
>> Error running python script
>/usr/libexec/perf-core/scripts/python/flamegraph.py
>> 
>> Installing libpython3-dev doesn't help.
>
>Hmm, I was hoping that I can drop support for Python 2 in 2020 ;) (it's
>
>officially EOL since Jan 1, 2020)
>
>The Ubuntu 18.04 release notes mention that "Python 2 is no longer 
>installed by default. Python 3 has been updated to 3.6. This is the
>last 
>LTS release to include Python 2 in main." 
>(https://wiki.ubuntu.com/BionicBeaver/ReleaseNotes) - so imho it should
>
>be fine to drop Python 2 support.
>
>I tested it with a Ubuntu VM, and by default the Python bindings aren't
>
>enabled in perf (see 
>https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1707875).
>
>But you can compile perf and select Python 3:
>
>$ make -j2 PYTHON=python3
>

I plan to make this the default soon.

- Arnaldo
>in the perf source directory (libpython3-dev must be installed).
>
>
>Does this work for you?
>
>
>Cheers,
>Andreas

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.