Re: [PATCH net-next] cxgb4: remove set but not used variable 'tab'
From: David Miller
Date: Tue Mar 24 2020 - 19:12:13 EST
From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Tue, 24 Mar 2020 14:26:14 +0800
> @@ -544,7 +544,7 @@ int cxgb4_get_free_ftid(struct net_device *dev, u8 family, bool hash_en,
> {
> struct adapter *adap = netdev2adap(dev);
> struct tid_info *t = &adap->tids;
> - struct filter_entry *tab, *f;
> + struct filter_entry *f;
> u32 bmap_ftid, max_ftid;
> unsigned long *bmap;
> bool found = false;
Please preserve the reverse christmas tree ordering here.