RE: [EXT] Re: [v1,iproute2 1/2] iproute2:tc:action: add a gate control action

[Po Liu]

Hi Stephen,


> -----Original Message-----
> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Sent: 2020年3月25日 5:59
> To: Po Liu <po.liu@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; vinicius.gomes@xxxxxxxxx; Claudiu Manoil
> <claudiu.manoil@xxxxxxx>; Vladimir Oltean <vladimir.oltean@xxxxxxx>;
> Alexandru Marginean <alexandru.marginean@xxxxxxx>; Xiaoliang Yang
> <xiaoliang.yang_1@xxxxxxx>; Roy Zang <roy.zang@xxxxxxx>; Mingkai Hu
> <mingkai.hu@xxxxxxx>; Jerry Huang <jerry.huang@xxxxxxx>; Leo Li
> <leoyang.li@xxxxxxx>; michael.chan@xxxxxxxxxxxx; vishal@xxxxxxxxxxx;
> saeedm@xxxxxxxxxxxx; leon@xxxxxxxxxx; jiri@xxxxxxxxxxxx;
> idosch@xxxxxxxxxxxx; alexandre.belloni@xxxxxxxxxxx;
> UNGLinuxDriver@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; jhs@xxxxxxxxxxxx;
> xiyou.wangcong@xxxxxxxxx; simon.horman@xxxxxxxxxxxxx;
> pablo@xxxxxxxxxxxxx; moshe@xxxxxxxxxxxx; m-karicheri2@xxxxxx;
> andre.guedes@xxxxxxxxxxxxxxx; David Ahern <dsahern@xxxxxxxxx>
> Subject: [EXT] Re: [v1,iproute2 1/2] iproute2:tc:action: add a gate control
> action
> 
> Caution: EXT Email
> 
> On Tue, 24 Mar 2020 11:47:44 +0800
> Po Liu <Po.Liu@xxxxxxx> wrote:
> 
> > diff --git a/include/uapi/linux/pkt_cls.h
> > b/include/uapi/linux/pkt_cls.h index a6aa466..7a047a9 100644
> > --- a/include/uapi/linux/pkt_cls.h
> > +++ b/include/uapi/linux/pkt_cls.h
> > @@ -106,6 +106,7 @@ enum tca_id {
> >       TCA_ID_SAMPLE = TCA_ACT_SAMPLE,
> >       TCA_ID_CTINFO,
> >       TCA_ID_MPLS,
> > +     TCA_ID_GATE,
> >       TCA_ID_CT,
> >       /* other actions go here */
> >       __TCA_ID_MAX = 255
> 
> All uapi headers need to come from checked in kernel.
> 
> This is an example of why, you have an out of date version because this
> version would have broken ABI.
> 
> 
> This patch should be against iproute2-next since because it depends on
> net-next.

I'll keep up with the iproute2-next branch. Thanks!

Br,
Po Liu