Re: [PATCH 1/6] MIPS: remove cpu_has_64bit_gp_regs and cpu_has_64bit_addresses
From: Christoph Hellwig
Date: Wed Mar 25 2020 - 04:58:56 EST
On Wed, Mar 25, 2020 at 09:55:24AM +0100, Fredrik Noring wrote:
> > The only use of cpu_has_64bit_addresses is the choice of the ioremap
> > code base. Which ioremap code does the R5900 want to use? If it
> > doesn't match CONFIG_64BIT having a config option for the ioremap
> > implementation seems much more sensible, and can be added with the
> > R5900 patch set (do you have a link to it?).
>
> I suppose this would be relevant for the n32 ABI, but initially we only
> have o32 for the R5900.
To enable ABIs you'll need Kconfig symbols, cpu_has_64bit_addresses
isn't going to be very useful for that. Which kinda rather was the
point of this patch - to use the existing Kconfig symbol rather than
two redundant defines that caused a lot weird cargo culting.
> The (slightly outdated) patch series under review
> is available here:
>
> https://lore.kernel.org/linux-mips/cover.1567326213.git.noring@xxxxxxxxxx/T/
You don't happen to have a git tree available somewhere?