Re: [PATCH 6/6] ptp_ocelot: support 4 programmable pins

From: Richard Cochran
Date: Wed Mar 25 2020 - 09:15:40 EST


On Fri, Mar 20, 2020 at 06:37:26PM +0800, Yangbo Lu wrote:
> Support 4 programmable pins for only one function periodic
> signal for now.

For now?

> +static int ocelot_ptp_verify(struct ptp_clock_info *ptp, unsigned int pin,
> + enum ptp_pin_function func, unsigned int chan)
> +{
> + switch (func) {
> + case PTP_PF_NONE:
> + case PTP_PF_PEROUT:
> + break;

If the functions cannot be changed, then supporting the
PTP_PIN_SETFUNC ioctl does not make sense!

> + case PTP_PF_EXTTS:
> + case PTP_PF_PHYSYNC:
> + return -1;
> + }
> + return 0;
> +}

Thanks,
Richard