Re: [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw
From: Andy Shevchenko
Date: Wed Mar 25 2020 - 10:42:42 EST
On Wed, Mar 25, 2020 at 02:41:50PM +0100, Heiko Stübner wrote:
> Am Montag, 23. März 2020, 14:41:06 CET schrieb Andy Shevchenko:
> > On Mon, Mar 23, 2020 at 02:17:14PM +0100, Lukas Wunner wrote:
> > > On Mon, Mar 23, 2020 at 09:25:57AM +0100, Heiko Stübner wrote:
> > > > Am Donnerstag, 19. März 2020, 06:40:34 CET schrieb Lukas Wunner:
> >
> > > "rs485-re-gpios" seems a bit cryptic, how about "rs485-rx-enable-gpios"
> > > or "rs485-full-duplex-gpios"?
> >
> > First is in align with well established pin name, second is its elaboration,
> > I'm for any, but last.
>
> So I guess the intersection of both your preferences
> is "rs485-rx-enable-gpios" ... and I did go with that ;-)
> I've now moved my rs485 things over to tty-next + taking
> - "serial: Allow uart_get_rs485_mode() to return errno"
> - "serial: 8250: Support rs485 bus termination GPIO"
> from Lukas' git-tree + fixing other things according to review comments.
>
> I guess I'll now just sit on things till after the 5.7 merge window for
> the depending patches to get posted.
Sounds like a plan, thank you!
Or you can post anyway and resend after merge window. People will have a chance
to look at this.
--
With Best Regards,
Andy Shevchenko