Re: [PATCH kunit-next] kunit: kunit_tool: Allow .kunitconfig to disable config items

From: Brendan Higgins
Date: Wed Mar 25 2020 - 13:19:09 EST


On Mon, Mar 23, 2020 at 7:43 PM David Gow <davidgow@xxxxxxxxxx> wrote:
>
> Rework kunit_tool in order to allow .kunitconfig files to better enforce
> that disabled items in .kunitconfig are disabled in the generated
> .config.
>
> Previously, kunit_tool simply enforced that any line present in
> .kunitconfig was also present in .config, but this could cause problems
> if a config option was disabled in .kunitconfig, but not listed in .config
> due to (for example) having disabled dependencies.
>
> To fix this, re-work the parser to track config names and values, and
> require values to match unless they are explicitly disabled with the
> "CONFIG_x is not set" comment (or by setting its value to 'n'). Those
> "disabled" values will pass validation if omitted from the .config, but
> not if they have a different value.
>
> Signed-off-by: David Gow <davidgow@xxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Thanks!