Re: [PATCH] nvme: Fix NVME_IOCTL_ADMIN_CMD compat address handling.

From: Nick Bowler
Date: Wed Mar 25 2020 - 16:47:37 EST


On 2020-03-25, Keith Busch <kbusch@xxxxxxxxxx> wrote:
> On Wed, Mar 25, 2020 at 12:11:03PM -0700, Christoph Hellwig wrote:
>> A couple of comments:
>>
>> No need for the "." the end of the subject line.
>>
>> I also think you should just talk of the nvme_user_cmd function,
>> as that also is used for the NVME_IOCTL_IO_CMD ioctl. Also there now
>> is a nvme_user_cmd64 variant that needs the same fix, can you also
>> include that?
>
> Yes, this patch should get those cases too.
>
> I unstaged this patch for now, could you send a v2 with the suggestions?

Will do.

Cheers,
Nick