Re: [RFC PATCH 1/1] Bluetooth: Update add_device to accept flags

[Marcel Holtmann]

Hi Abhishek,

> Add the capability to set flags on devices being added via add_device.
> The first flag being used is the wakeable flag which allows the device
> to wake the system from suspend.
> 
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx>
> ---
> 
> include/net/bluetooth/mgmt.h |  5 ++++-
> net/bluetooth/mgmt.c         | 42 +++++++++++++++++++++++++++++++++++-
> 2 files changed, 45 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index f41cd87550dc..e9db9b1a4436 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -445,8 +445,11 @@ struct mgmt_rp_get_clock_info {
> struct mgmt_cp_add_device {
> 	struct mgmt_addr_info addr;
> 	__u8	action;
> +	__u8	flags_mask;
> +	__u8	flags_value;
> } __packed;
> -#define MGMT_ADD_DEVICE_SIZE		(MGMT_ADDR_INFO_SIZE + 1)
> +#define MGMT_ADD_DEVICE_SIZE		(MGMT_ADDR_INFO_SIZE + 3)

as I mentioned in the other review. This is not backwards compatible.

Regards

Marcel