Re: [PATCH v1] slimbus: core: Set fwnode for a device when setting of_node

From: Srinivas Kandagatla
Date: Thu Mar 26 2020 - 09:09:05 EST


Thanks for doing this!

On 26/03/2020 06:16, Saravana Kannan wrote:
When setting the of_node for a newly created device, also set the
fwnode. This allows fw_devlink to work for slimbus devices.

Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
Change-Id: I5505213f8ecca908860a1ad6bbc275ec0f78e4a6

Once Change-Id is removed as Greg suggested!

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

--srini

---
drivers/slimbus/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 526e3215d8fe..44228a5b246d 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -163,8 +163,10 @@ static int slim_add_device(struct slim_controller *ctrl,
INIT_LIST_HEAD(&sbdev->stream_list);
spin_lock_init(&sbdev->stream_list_lock);
- if (node)
+ if (node) {
sbdev->dev.of_node = of_node_get(node);
+ sbdev->dev.fwnode = of_fwnode_handle(node);
+ }
dev_set_name(&sbdev->dev, "%x:%x:%x:%x",
sbdev->e_addr.manf_id,