Re: [PATCH] ethtool: Report speed and duplex as unknown when device is runtime suspended

[Florian Fainelli]

On 3/26/2020 7:45 PM, Kai-Heng Feng wrote:
> Device like igb gets runtime suspended when there's no link partner. We
> can't get correct speed under that state:
> $ cat /sys/class/net/enp3s0/speed
> 1000
> 
> In addition to that, an error can also be spotted in dmesg:
> [  385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost
> 
> Since device can only be runtime suspended when there's no link partner,
> we can directly report the speed and duplex as unknown.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: Aaron Brown <aaron.f.brown@xxxxxxxxx>
> Suggested-by: Alexander Duyck <alexander.duyck@xxxxxxxxx>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>

I would push this to the responsibility of the various drivers instead
of making this part of the standard ethtool implementation.
-- 
Florian